diff --git a/README.md b/README.md index ac07a84d..c3e77062 100755 --- a/README.md +++ b/README.md @@ -28,6 +28,35 @@ A place to learn and share with developers what makes web work accessible. This - You can find the path to the installed PHP using `which php`. Add that path to your terminal profile's PATH environment value and/or VS Code settings. - Java: required in order to use the v.Nu checker during automation and unit testing + - Install options: + + - Brew Install Options: + + - ```bash + brew install java + ``` + - ```bash + brew install openjdk + ``` + - Additional tasks + + - ```bash + java -version + ``` + + If you get "Unable to locate a Java Runtime", proceed to next step. + + - Ensure your symlink is correctly mapped (these instructions will also appear after you brew install java) + + - ```bash + sudo ln -sfn /opt/homebrew/opt/openjdk/libexec/openjdk.jdk \ + /Library/Java/JavaVirtualMachines/openjdk.jdk + ``` + + - Manual Install Options: + - Mac Install + - Windows Install + > Note: Any changes to these prerequisites will need to be reflected in the GitHub Actions in order to run the CI/CD checks. #### Optional installations (since `npm run server` will run an express server) @@ -59,6 +88,8 @@ A place to learn and share with developers what makes web work accessible. This > See the [Chromedriver issues](#chromedriver-issues) section if you encounter an error related to Chromedriver. + > Make sure your local server is running in another terminal before running `npm run test`. + ## Tests ### Tools used for testing diff --git a/bin/php-express/lib/PHPExpress/index.js b/bin/php-express/lib/PHPExpress/index.js index ace85011..91f76126 100644 --- a/bin/php-express/lib/PHPExpress/index.js +++ b/bin/php-express/lib/PHPExpress/index.js @@ -13,7 +13,10 @@ var PHPExpress = function (opts) { console.log(`Error was: ${error || stderr}`) process.exit(1); } else { - this.binPath = stdout.trim(); + const stdoutVal = stdout.trim(); + if (stdoutVal !== '') { + this.binPath = stdoutVal; + } console.log(`PHP found at ${this.binPath}`); } });