-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to TypeScript 5.5 #77
Comments
will look into this ASAP thx @Ewok167 |
@Ewok167 done please test |
check since v9.9.0 |
Thanks. But it doesn't seem to have fixed my issue, hmm. It seems related to esbuild or the way I use it. I found some other libraries with the issue too... |
@Ewok167 how do you import the library?
should normally work what error you get? can you create a minimal example repository I can look at? I'm reopening the issue since you say it's not done yet mind you, the library is in typescript in src and the dist folder is compiled tsc compiled 5.5 into https://github.com/Prozi/detect-collisions/blob/master/tsconfig.json#L12 target: es2015 it should work totally in any environment node webpack rollup browser as module import whatever |
@Ewok167 I have no clue why in your project
doesn't work, maybe the problem is elsewhere in your code why? https://github.com/Prozi/detect-collisions/blob/master/package.json#L5 that's why |
closing as I cannot reproduce so I wont fix and you @Ewok167 didnt provide any example repository |
Hi. Unless I'm mistaken, using TypeScript 5.5 should allow importing the library properly. As described here: Easier API Consumption from ECMAScript Modules.
Because I have the same issue as described in this PR: microsoft/TypeScript#57133 when using this library.
Some other dependencies, including RBush, have updates as well.
None of the updates should require any significant changes, if any.
The text was updated successfully, but these errors were encountered: