Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to TypeScript 5.5 #77

Closed
Ewok167 opened this issue Jun 27, 2024 · 7 comments
Closed

Update to TypeScript 5.5 #77

Ewok167 opened this issue Jun 27, 2024 · 7 comments

Comments

@Ewok167
Copy link

Ewok167 commented Jun 27, 2024

Hi. Unless I'm mistaken, using TypeScript 5.5 should allow importing the library properly. As described here: Easier API Consumption from ECMAScript Modules.

Because I have the same issue as described in this PR: microsoft/TypeScript#57133 when using this library.

Some other dependencies, including RBush, have updates as well.

None of the updates should require any significant changes, if any.

@Prozi
Copy link
Owner

Prozi commented Jul 14, 2024

will look into this ASAP thx @Ewok167

@Prozi
Copy link
Owner

Prozi commented Jul 15, 2024

@Ewok167 done please test

@Prozi
Copy link
Owner

Prozi commented Jul 15, 2024

check since v9.9.0

@Prozi Prozi closed this as completed Jul 15, 2024
@Ewok167
Copy link
Author

Ewok167 commented Jul 15, 2024

@Ewok167 done please test

Thanks. But it doesn't seem to have fixed my issue, hmm. It seems related to esbuild or the way I use it. I found some other libraries with the issue too...

@Prozi
Copy link
Owner

Prozi commented Jul 17, 2024

@Ewok167 how do you import the library?

import { System } from 'detect-collisions';

should normally work

what error you get?

can you create a minimal example repository I can look at?

I'm reopening the issue since you say it's not done yet

mind you, the library is in typescript in src and the dist folder is compiled tsc compiled 5.5 into

https://github.com/Prozi/detect-collisions/blob/master/tsconfig.json#L12

target: es2015

it should work totally in any environment node webpack rollup browser as module import whatever

@Prozi Prozi reopened this Jul 17, 2024
@Prozi
Copy link
Owner

Prozi commented Jul 17, 2024

@Ewok167 I have no clue why in your project

import { System } from 'detect-collisions'

doesn't work, maybe the problem is elsewhere in your code


why?

https://github.com/Prozi/detect-collisions/blob/master/package.json#L5
https://github.com/Prozi/detect-collisions/blob/master/dist/index.js#L40
https://github.com/Prozi/detect-collisions/blob/master/dist/system.js#L181

that's why

@Prozi
Copy link
Owner

Prozi commented Jul 19, 2024

closing as I cannot reproduce so I wont fix

and you @Ewok167 didnt provide any example repository

@Prozi Prozi closed this as not planned Won't fix, can't repro, duplicate, stale Jul 19, 2024
@Prozi Prozi reopened this Jul 19, 2024
@Prozi Prozi closed this as completed Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants