Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Property 'pos' does not exist on type 'Polygon' #17

Closed
hpx7 opened this issue Nov 25, 2021 · 5 comments
Closed

Property 'pos' does not exist on type 'Polygon' #17

hpx7 opened this issue Nov 25, 2021 · 5 comments

Comments

@hpx7
Copy link

hpx7 commented Nov 25, 2021

On the latest version typescript complains when i try and update the position of a polygon

@Pii2
Copy link

Pii2 commented Nov 25, 2021

#16 :)

@hpx7
Copy link
Author

hpx7 commented Nov 26, 2021

Cool, for me adding

    "@types/rbush": "^3.0.0",
    "@types/sat": "^0.0.31",

as devDependencies fixed it.

I think these should be in dependencies in this package instead of devDependencies so that this works out of the box for users.

For additional discussion on this topic see https://www.reddit.com/r/typescript/comments/byar8w/tool_to_tell_me_which_types_deps_should_be_deps/

@Prozi
Copy link
Owner

Prozi commented Nov 26, 2021

@hpx7 @Pii2

I have moved the types above-mentioned by hpx7 in the dependencies since version 3.1.0

can you try that and see if it's better and doesnt require workarounds anymore?

thank you.

@Pii2
Copy link

Pii2 commented Dec 1, 2021

Hey, yes now it works out of the box, good work :)

@Prozi
Copy link
Owner

Prozi commented Dec 4, 2021

thanks :) closing then

@Prozi Prozi closed this as completed Dec 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants