Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

webpack is failing to build / deploy - upgrade needed to support critical (has a headless chrome dependency) #143

Closed
1 of 4 tasks
thescientist13 opened this issue Apr 2, 2018 · 0 comments · Fixed by #144
Closed
1 of 4 tasks

webpack is failing to build / deploy - upgrade needed to support critical (has a headless chrome dependency) #143

thescientist13 opened this issue Apr 2, 2018 · 0 comments · Fixed by #144
Assignees
@thescientist13
Labels
0.3.0 webpack v4 upgrades and continued performance improvents P0 technical

Comments

@thescientist13
Copy link
Contributor

thescientist13 commented Apr 2, 2018 •
edited
Loading

Type of Change

  • New Feature Request
  • Improvement / Suggestion
  • Bug
  • Other (please clarify below)

Summary

Noticed that after merging #142 the build didn't deploy to stage. Observed that the build never completed and deployed
https://circleci.com/gh/ProvidenceGeeks/website-frontend/328
screen shot 2018-04-02 at 2 30 55 pm

Looked in the PR build and they also didn't build.
https://circleci.com/gh/ProvidenceGeeks/website-frontend/327

Tracked it down to this in the html-critical-webpack-plugin repo

The solution here specifically is to get support for puppeteer integrated into the CI build.
@thescientist13 thescientist13 self-assigned this Apr 2, 2018
@thescientist13 thescientist13 added the 0.3.0 webpack v4 upgrades and continued performance improvents label Apr 2, 2018
@thescientist13 thescientist13 mentioned this issue Apr 2, 2018
Merged
@thescientist13 thescientist13 changed the title webpack is failing to build / deploy - upgrade needed to support headless chrome webpack is failing to build / deploy - upgrade needed to support critical (has a headless chrome dependency) Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thescientist13 thescientist13

Labels
0.3.0 webpack v4 upgrades and continued performance improvents P0 technical
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

use different image to support critical dependency on puppeteer ProvidenceGeeks/website-frontend
1 participant
@thescientist13