Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clarify usage of prerender option in relation to Renderer plugins #149

Open
thescientist13 opened this issue Dec 13, 2024 · 0 comments · May be fixed by #152
Open

clarify usage of prerender option in relation to Renderer plugins #149

thescientist13 opened this issue Dec 13, 2024 · 0 comments · May be fixed by #152
Assignees
Labels
docs Greenwood specific content like docs and guides release/v0.31.0

Comments

@thescientist13
Copy link
Member

thescientist13 commented Dec 13, 2024

Summary

Coming out of discussions / feedback related two ProjectEvergreen/greenwood#1343, it was the takeaway that it probably doesn't make much sense to have to settings for the same thing. If the user wants to enable prerendering, the single configuration option in greenwood.config.js should be sufficient. Since the plugin has access to the compilation and all its options, it can derive its behavior / support based on that and / or in its documentation.

Details

So the goal here should be to just align with the new convention we're setting going forward and update the Renderer Plugin API docs accordingly - https://greenwoodjs.dev/docs/reference/plugins-api/#renderer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Greenwood specific content like docs and guides release/v0.31.0
Projects
Status: 👀 In review
1 participant