Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

assets (fonts) with query strings not loading correctly with production build (greenwood serve) #764

Closed
1 of 5 tasks
thescientist13 opened this issue Oct 12, 2021 · 0 comments · Fixed by #765
Closed
1 of 5 tasks
Assignees
Labels
bug Something isn't working CLI v0.17.0
Milestone

Comments

@thescientist13
Copy link
Member

Type of Change

  • New Feature Request
  • Documentation / Website
  • Improvement / Suggestion
  • Bug
  • Other (please clarify below)

Summary

Noticed that when integrating font-awesome into a project, it uses query strings within its file reference to its font files from its CSS.

@font-face {
  font-family: 'FontAwesome';
  src: url('../fonts/fontawesome-webfont.eot?v=4.6.3');
  src: url('../fonts/fontawesome-webfont.eot?#iefix&v=4.6.3') format('embedded-opentype'), url('../fonts/fontawesome-webfont.woff2?v=4.6.3') format('woff2'), url('../fonts/fontawesome-webfont.woff?v=4.6.3') format('woff'), url('../fonts/fontawesome-webfont.ttf?v=4.6.3') format('truetype'), url('../fonts/fontawesome-webfont.svg?v=4.6.3#fontawesomeregular') format('svg');
  font-weight: normal;
  font-style: normal;
}

This causes an issue with the prod server wherein this content (with a query string) is not loaded. (Returns a 204)
Screen Shot 2021-10-12 at 11 32 33 AM

Details

This seems similar to a previous bug #579 but looks like I may have missed a case where i need to strip query params before handing off a URL for file resolution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CLI v0.17.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant