Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve support for package.json exports when building up import maps #1317

Closed
thescientist13 opened this issue Nov 14, 2024 · 0 comments · Fixed by #1326
Closed

improve support for package.json exports when building up import maps #1317

thescientist13 opened this issue Nov 14, 2024 · 0 comments · Fixed by #1326
Assignees
Labels
alpha.0 CLI enhancement Improve something existing (e.g. no docs, new APIs, etc) v0.31.0
Milestone

Comments

@thescientist13
Copy link
Member

thescientist13 commented Nov 14, 2024

Type of Change

Enhancement

Summary

As part of integrating with various ecosystem libraries, it has been observed that additional cases need to be accounted for when handling the exports object from a package.json

Details

Observed and reported use cases that we should validate against

While we're here, we should probably also try and improve our error handling here, like making sure only strings get added to the import map, and good use of try / catch

@thescientist13 thescientist13 added enhancement Improve something existing (e.g. no docs, new APIs, etc) CLI labels Nov 14, 2024
@thescientist13 thescientist13 added this to the 1.0 milestone Nov 14, 2024
@thescientist13 thescientist13 self-assigned this Nov 16, 2024
@thescientist13 thescientist13 moved this from 🔖 Ready to 🏗 In progress in [Greenwood] Phase 10 - Ecosystem Compat Nov 16, 2024
@thescientist13 thescientist13 pinned this issue Nov 25, 2024
@thescientist13 thescientist13 unpinned this issue Nov 25, 2024
@thescientist13 thescientist13 moved this from 🏗 In progress to 👀 In review in [Greenwood] Phase 10 - Ecosystem Compat Nov 27, 2024
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in [Greenwood] Phase 10 - Ecosystem Compat Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alpha.0 CLI enhancement Improve something existing (e.g. no docs, new APIs, etc) v0.31.0
Projects
1 participant