Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong highway tag in bicycle.profile #6289

Closed
davidmurray opened this issue Jul 28, 2022 · 2 comments
Closed

Wrong highway tag in bicycle.profile #6289

davidmurray opened this issue Jul 28, 2022 · 2 comments

Comments

@davidmurray
Copy link

Hello,

In the bicycle OSRM profile, there is a check for the bicycle highway tag in the safety_handler function.

if data.highway == "bicycle" then
safety_bonus = safety_bonus + 0.2
if result.forward_speed > 0 then
-- convert from km/h to m/s
result.forward_rate = result.forward_speed / 3.6 * safety_bonus
end
if result.backward_speed > 0 then
-- convert from km/h to m/s
result.backward_rate = result.backward_speed / 3.6 * safety_bonus
end
if result.duration > 0 then
result.weight = result.duration / safety_bonus
end
end

However, unless I am mistaken, there is no highway=bicycle tag in OSM, but rather a highway=cycleway tag: https://wiki.openstreetmap.org/wiki/Key:highway

Therefore, shouldn't this code check for "cycleway" rather than "bicycle"?

Thanks!

@SiarheiFedartsou
Copy link
Member

Related #6296

@SiarheiFedartsou
Copy link
Member

Closing as this code does not exist anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants