-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remodel data storage #1907
Comments
Will also fix #1894 |
This will allow multiple shared memory on same host ? |
Yes, via named shared memory; e.g. for multiple profiles. |
We need to implement a notification/wait strategy for data reloading as well. There is currently some confusion about which process is responsible for cleaning up no-longer-used shared memory. The workflow should be:
Currently, the readers remove the old block themselves, and |
It would be great to be able to run multiple instances of osrm-routed with different profiles, ie osrm-datastore should be able to keep multiple data source in memory at once. |
@danpat you refactored the data facades - care to have a look here and either update what still needs to be done or close this and split off a different issue with remaining task. |
#3165 consolidated the logic behind the two datafacades - we now only have a single file-loading codepath. The only thing we haven't done is make the shared memory regions named. |
Current we support two data backends hidden behind
BaseDatafacade
. Both codes uses different code paths for loading data into memory, ideally it should be the same.The whole data backend should be re-written:
libosrm-storage
@danpat @daniel-j-h extend if you have any more points
The text was updated successfully, but these errors were encountered: