You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I believe that using "include_channel_zero" as an alternative to "include_background" may not be the best choice due to the loss of argument semantics. In contrast, the name "include_background" directly conveys the purpose of this argument to the user. The core issue of original post is that the channel of background is confusing. One potential solution could be to introduce an optional argument, such as background_channel: int | Sequence[int] = 0, to clarify this aspect. BTW, argument such as include_channel: int | Sequence[int] = 0 could be better than "include_channel_zero" .
I actually like "include_background", and I'd vote to keep it as is, simply because we've been using it for a long time now. And in the class doc it's explained what it means, if anyone is confused, it's really easy to read the doc (or comment in the class .py) . I've never encountered situations when the background (if present) is at a different non-zero channel. Unless there is a real use-case, I don't think we should over-complicate the api.
Originally posted by @ChenglongWang in #6915 (comment)
See whole discussion for further feedback.
The text was updated successfully, but these errors were encountered: