Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PydicomReader (0028, 0030) Pixel Spacing #6159

Closed
wyli opened this issue Mar 16, 2023 · 3 comments
Closed

PydicomReader (0028, 0030) Pixel Spacing #6159

wyli opened this issue Mar 16, 2023 · 3 comments

Comments

@wyli
Copy link
Contributor

wyli commented Mar 16, 2023

When using PydicomReader to read a dcm slice(2d), we didn't correctly record the spacing. Maybe using (0028, 0030) Pixel Spacing this tag can be safer.

MONAI/monai/data/image_reader.py

Line 687 in 678b512

dr, dc = metadata.get("spacing", (1.0, 1.0))[:2]

Originally posted by @KumoLiu in #6136 (comment)
@wyli
Copy link
Contributor Author

wyli commented Apr 11, 2023

we can compute this from existing metadata, cf #6136 (comment), closing the ticket for now, feel free to reopen

@wyli wyli closed this as completed Apr 11, 2023
@phcerdan
Copy link

Is this fixed? I am hitting exactly this with old Monai 1.1 using PydicomReader.
Are we reading affine directly instead of metadata.spacing? Thanks!

@wyli
Copy link
Contributor Author

wyli commented Apr 14, 2023

Are we reading affine directly instead of metadata.spacing?

yes, reading affine and you can access the spacing via metatensor.pixdim

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wyli @phcerdan