New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update engines according to discussion #4148

Closed

Nic-Ma opened this issue Apr 19, 2022 · 0 comments · Fixed by #4150

Assignees

Labels

Milestone

Bug Fixes or Misc...

Contributor

Nic-Ma commented Apr 19, 2022

Is your feature request related to a problem? Please describe.
According to the discussion in #4132 , would be nice to update:

Still defining _iteration() as a regular method, but unify all the self.XXX and engine.XXX to engine.XXX. Because (1) as you said users can easily copy-paste our code, (2) maybe someone will override the engine run logic someday and pass other engine as parameter instead of self: https://github.com/pytorch/ignite/blob/master/ignite/engine/engine.py#L859.
Check all the engine: Engine functions, if having MONAI specific logic, change the typehint to Workflow.

The text was updated successfully, but these errors were encountered:

Nic-Ma self-assigned this

Nic-Ma added the enhancement label

Nic-Ma added this to MONAI 0.9

Nic-Ma added this to the Bug Fixes or Misc improvements milestone

Nic-Ma mentioned this issue

4148 Enhance engine iteration logic and the typehints #4150

Merged

7 tasks

Nic-Ma closed this as completed in #4150

Nic-Ma moved this to Done in MONAI 0.9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment