Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enables more flexible writer signature in TensorBoardHandler #3429

Closed
YuanTingHsieh opened this issue Dec 2, 2021 · 0 comments · Fixed by #3431
Closed

Enables more flexible writer signature in TensorBoardHandler #3429

YuanTingHsieh opened this issue Dec 2, 2021 · 0 comments · Fixed by #3431
Assignees
Labels
enhancement New feature or request

Comments

@YuanTingHsieh
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
I want to use the TensorBoardHandler but my custom writer would requires more context from engine.

The logic in this line https://github.com/Project-MONAI/MONAI/blob/dev/monai/handlers/tensorboard_handlers.py#L224
required writer to have this fixed signature.

I would like to implement a custom writer which needs information from the engine, but can still reuse the same logic to get loss and metric of the default logger.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants