Make it possible to check the result of PRs

[rom1504]

put html code in an artifact on PRs will allow testing before merging

[rom1504]

https://github.com/PrismarineJS/prismarine-viewer/blob/master/.github/workflows/ci.yml#L34
there https://github.com/PrismarineJS/prismarine-web-client/blob/master/.github/workflows/ci.yml#L46

put a if pr

[rom1504]

instead it could be nice to put the result in a subfolder in gh pages and post a message on the github issue to go to http://webclient.prismarine.js.org/PR_number/

this would need:

• push to that folder on pr event
• delete folder on pr closed/merged event
• make sure not to fail due to concurrent push

[DeltaEvo]

Another solution could be to use a service that already has this feature like netlify, vercel, cloudflare pages, ...

[AwesomestCode]

Took a quick look and all of those seem to be paid over a certain number of minutes. During times this repo is most active, we can have 5 PRs being worked on concurrently, each with around 6 commits a day. Each one takes 5 minutes to build (which may be an underestimate since they probably provide underpowered VMs), leading to 4,500 build minutes. That’s way above any of their limits.On Wed, Aug 25, 2021 at 03:53, David Duarte ***@***.***> wrote: Another solution could be to use a service that already has this feature like netlify, vercel, cloudflare pages, ... —You are receiving this because you are subscribed to this thread.Reply to this email directly, view it on GitHub, or unsubscribe.

[DeltaEvo]

I don't think it's a big issue, because if the limit is exceeded it will juste make the pr preview unavailable.

If needed all of thoose services have open source plans

For netlify you can also not rely on build minutes if you use the github action https://github.com/netlify/actions, but it's more work