Better handling of other loginwrapperchannel (FML2, FML3) #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rom1504
reviewed
Jan 3, 2024
src/client/forgeHandshake2.js
Outdated
| loginwrapper.channel, | ||
| 'received' | ||
| ) | ||
| console.log('other loginwrapperchannel', loginwrapper.channel, 'received') |
|
I don't think these messages will be noticed by user upon successful login, because they'll be followed by a wall of text before bot spawns (like "Chunk size is 90781 but only 82244 was read ; partial packet..."). But I made the messaging here more concise for the sake of clarity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some errors upon login reported with the current implementation of FML2 & FML3 protocol. Examples: Quark mod (version 410+, FML3), MrCrayfish's Gun Mod (both FML2 & 3). These mods use custom handshakes.
The way to deal with it is to acknowledge any packet from other loginwrapperchannels (from mods). This is enough to login with mentioned mods, but I implement this in try...catch block should it ever lead to an exception in some other unknown cases. Acknowledgments to @letschill, to whose code I returned while implementing this change.
Fixes #29