Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failing block-related tests #649

Open
Pandapip1 opened this issue Jan 8, 2024 · 4 comments
Open

Fix failing block-related tests #649

Pandapip1 opened this issue Jan 8, 2024 · 4 comments

Comments

@Pandapip1
Copy link
Contributor

Pandapip1 commented Jan 8, 2024 •
edited
Loading

The 'place a block', 'can open and close a chest', and/or /setblock tests inconsistently fail for no apparent reason.
@rom1504
Copy link
Member

rom1504 commented Jan 1, 2025

https://github.com/PrismarineJS/flying-squid/actions/runs/12569838389/job/35038952697

@extremeheat extremeheat mentioned this issue Jan 2, 2025
Merged
@rom1504
Copy link
Member

rom1504 commented Jan 4, 2025

looks fixed

@rom1504 rom1504 closed this as completed Jan 4, 2025
@extremeheat
Copy link
Member

Seems the tests are mostly failing on the "before each" hook at not the tests themselves, and --retries doesn't work on beforeEach

@rom1504 rom1504 reopened this Jan 4, 2025
@rom1504
Copy link
Member

rom1504 commented Jan 4, 2025

yeah I guess we should fix the root cause...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rom1504 @extremeheat @Pandapip1