Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tab complete & /give, /effect improvements #635

Merged
merged 9 commits into from
Dec 31, 2023
Merged

tab complete & /give, /effect improvements #635

merged 9 commits into from
Dec 31, 2023

Conversation

zardoy
Copy link
Contributor

@zardoy zardoy commented Sep 3, 2023 •
edited
Loading

/give:

  1. can use name in any form
  2. issues message if an item is not found so the player understands why an item is not given
  3. works with non-empty inventories
  • completions for other commands (items, blocks, entities...)

@zardoy zardoy changed the title fix /give command /give fixes Sep 3, 2023
@zardoy zardoy marked this pull request as draft September 3, 2023 16:24
@zardoy
Copy link
Contributor Author

zardoy commented Sep 3, 2023 •
edited
Loading

Tab complete needs fixes. It doesn't work with 1.16 at all EDIT: now in another issue

@zardoy zardoy changed the title /give fixes tab complete & /give, /effect improvements Sep 9, 2023
@socket-security
Copy link

New dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
change-case 4.1.2 None +14 192 kB blakeembrey

@zardoy zardoy marked this pull request as ready for review October 13, 2023 18:28
@rom1504 rom1504 merged commit 2c1bc46 into PrismarineJS:master Dec 31, 2023
11 checks passed
@rom1504
Copy link
Member

rom1504 commented Dec 31, 2023

/makerelease

@rom1504bot rom1504bot mentioned this pull request Dec 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
PR Triage
Status: Closed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zardoy @rom1504