Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] DialogService prevent switch tabs on TabbedPage #1892

Closed
michaelmairegger opened this issue Sep 4, 2019 · 3 comments · Fixed by #2169
Closed

[Enhancement] DialogService prevent switch tabs on TabbedPage #1892

michaelmairegger opened this issue Sep 4, 2019 · 3 comments · Fixed by #2169

Comments

@michaelmairegger
Copy link
Contributor

Description

When opening a dialog by using IDialogService the dimmed background is only visible on the current page. If e.g. we have a TabbedPage the tabs-area is not disabled nor greyed out. Therefore the user can switch tabs.

Is there a possibility to prevent this behavior?

Steps to Reproduce

  1. Create a TabbedPage
  2. Open a dialog by using IDialogService

Expected Behavior

All the background is gray and the user should not be able to select the other tab.

Actual Behavior

The currenty page is gray only and the user is able to switch tabs,

Basic Information

  • Version with issue: 7.2.0.1367

Screenshots

2019-09-04

@dansiegel dansiegel changed the title [Bug] DialogService and TabbedPage [Enhancement] DialogService prevent switch tabs on TabbedPage Sep 4, 2019
@dansiegel dansiegel added the XF label Sep 4, 2019
@dansiegel
Copy link
Member

this will not be supported in the super near term as we are blocked by Xamarin.Forms... however I just spoke with @PureWeen it seems that xamarin/Xamarin.Forms#6558 from @andreinitescu should allow us to modify the way that we handle Dialogs to use an actual Modal page that will properly mask a Tab Bar, Navigation Bar, or a Master Detail Page.

@dansiegel
Copy link
Member

I should note that the best way to work around this issue will be from the upcoming release of Prism.Plugin.Popups which will have an implementation that injects your Dialog Content inside of a PopupPage this will properly overlay the Navigation bars in TabbedPages / NavigationPages

@dansiegel
Copy link
Member

moving this to roadmap... the original PR we were waiting on was closed, however the work we needed has been merged and should be available in the next release of Xamarin.Forms.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants