Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Analyzers with different internal libraries cannot be loaded side-by-side in VS #112

Closed
mdekrey opened this issue Mar 16, 2023 · 1 comment
Closed

Analyzers with different internal libraries cannot be loaded side-by-side in VS #112

mdekrey opened this issue Mar 16, 2023 · 1 comment
Assignees
@mdekrey
Labels
bug Something isn't working

Comments

@mdekrey
Copy link
Contributor

mdekrey commented Mar 16, 2023

Visual Studio loads all analyzers into the same memory space. This causes issues when upgrading internal libraries (in this project, that includes Handlebars.NET, SharpYaml, and other .NET libraries) - see dotnet/roslyn#41421.

The generally accepted approach is to move any assemblies that are not inherent to the Roslyn version into a dynamically-loaded Assembly Load Context to keep them separate.
@mdekrey mdekrey added the bug Something isn't working label Mar 16, 2023
@mdekrey mdekrey self-assigned this Mar 16, 2023
@mdekrey
Copy link
Contributor Author

mdekrey commented Mar 27, 2023

This was resolved with release 0.14.0 by embedding the related assemblies and writing a custom AssemblyResolve handler.

@mdekrey mdekrey closed this as completed Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mdekrey mdekrey

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mdekrey