Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mod will crash game if whitelist values contain invalid paths or characters #29

Open
valkyrienyanko opened this issue Jun 9, 2024 · 0 comments

Comments

@valkyrienyanko
Copy link

valkyrienyanko commented Jun 9, 2024

I knew adding the ID techreborn:sapphire_ore to the whitelist would work but I wanted to add all Tech Reborn ores so I was trying to figure out why #techreborn:mineable/omni_tool wasn't working. I think it's because the mod does not know how to handle forward slashes in the value. Anyways, I tried doing #c:techreborn:mineable/omni_tool because why not lets just try some value that I know won't work and then the game crashed with the following error

net.minecraft.util.InvalidIdentifierException: Non [a-z0-9/._-] character in path of location: c:techreborn:mineableomni_tool

Notice how there is no / in the value above even so I put one. Also please note that before I even knew the wiki existed I was trying values like <tag:block:techreborn:...> and the mod would crash because of the <> characters.

Please add a simple try catch to handle these scenarios for people like me that didn't know the wiki existed. And maybe whisper the player a message in game to the wiki talking about the blacklist / whitelist if they do try doing invalid paths or weird characters.

I am using this mod for Fabric 1.20.1

TL;DR

  • Add try catch to prevent crashing on invalid paths / characters
  • Add support for reading forward slash (/) in tags
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant