Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Autoupgrade - Error during upgrade to develop #26503

Closed
marwachelly opened this issue Nov 2, 2021 · 3 comments · Fixed by PrestaShop/autoupgrade#434 or #27276
Closed

Autoupgrade - Error during upgrade to develop #26503

marwachelly opened this issue Nov 2, 2021 · 3 comments · Fixed by PrestaShop/autoupgrade#434 or #27276
Assignees
@atomiix @jolelievre
Labels
8.0.x Branch Autoupgrade Module: autoupgrade BO Category: Back Office Bug Type: Bug Fixed Resolution: issue closed because fixed Major Severity: major bug > https://build.prestashop.com/news/severity-classification Module Module PR available Solution: issue is being addressed Regression Type: regression Verified The issue has been reproduced
Milestone
8.0.0

Comments

@marwachelly
Copy link

Describe the bug

There is an error during the autoupgrade to the 8.0.0.

Expected behavior

Autoupgrade to develop is possible with no error.

Steps to Reproduce

Steps to reproduce the behavior:

Steps to reproduce the behavior:

  1. Create a release 8.0.0 using (php tools/build/CreateRelease.php) from develop branch
  2. Autoupgrade the version 1.7.8.0 to 8.0.0 using local archive
  3. See error.

Screenshots
image

If applicable, add screenshots or screen recordings to help explain your problem.

Additional information

  • PrestaShop version: develop
  • PHP version: 7.3
  • 1-click upgrade 4.13.0
@marwachelly marwachelly added Autoupgrade Module: autoupgrade BO Category: Back Office Bug Type: Bug develop Branch Major Severity: major bug > https://build.prestashop.com/news/severity-classification Regression Type: regression In analysis Verified The issue has been reproduced labels Nov 2, 2021
@marwachelly marwachelly mentioned this issue Nov 2, 2021
Merged
@jolelievre
Copy link
Contributor

This is due to the removal of the deprecated method in this PR #26309

The autoupgrade module needs to be updated so that it doesn't use this method anymore.

@jolelievre jolelievre mentioned this issue Nov 2, 2021
Merged
@jolelievre
Copy link
Contributor

I proposed a fix in this PR PrestaShop/autoupgrade#434 but I have questions regarding retro compatibility of the autoupgrade module I'd like some feedback from core developers @PrestaShop/prestashop-core-developers

@eternoendless eternoendless added Needs Specs Status: issue needs to be specified and removed In analysis labels Nov 8, 2021
@hibatallahAouadni hibatallahAouadni added the PR available Solution: issue is being addressed label Nov 25, 2021
@marwachelly marwachelly mentioned this issue Dec 14, 2021
Merged
@MatShir MatShir added the Module Module label Dec 28, 2021
@marwachelly marwachelly mentioned this issue Dec 29, 2021
Merged
@prestashop-issue-bot prestashop-issue-bot bot added the WIP Status: Work In Progress label Dec 29, 2021
@hibatallahAouadni hibatallahAouadni removed the Needs Specs Status: issue needs to be specified label Jan 6, 2022
@atomiix atomiix mentioned this issue Jan 7, 2022
Merged
@atomiix atomiix linked a pull request Jan 7, 2022 that will close this issue
Remove useless legacyContextLoader #27276
Merged
@prestashop-issue-bot prestashop-issue-bot bot removed the WIP Status: Work In Progress label Jan 31, 2022
@hibatallahAouadni hibatallahAouadni added 8.0.x Branch and removed develop Branch labels Feb 7, 2022
@prestashop-issue-bot prestashop-issue-bot bot added the WIP Status: Work In Progress label Feb 7, 2022
@hibatallahAouadni hibatallahAouadni mentioned this issue Feb 15, 2022
Merged
@prestashop-issue-bot prestashop-issue-bot bot removed the WIP Status: Work In Progress label Feb 16, 2022
@prestashop-issue-bot prestashop-issue-bot bot added the Fixed Resolution: issue closed because fixed label Feb 16, 2022
@Progi1984 Progi1984 reopened this Feb 16, 2022
@prestashop-issue-bot prestashop-issue-bot bot removed the Fixed Resolution: issue closed because fixed label Feb 16, 2022
@prestashop-issue-bot prestashop-issue-bot bot added the Needs Specs Status: issue needs to be specified label Feb 16, 2022
@prestashop-issue-bot prestashop-issue-bot bot added Fixed Resolution: issue closed because fixed and removed Needs Specs Status: issue needs to be specified labels Feb 16, 2022
@Progi1984 Progi1984 added this to the 8.0.0 milestone Feb 16, 2022
@Progi1984
Copy link
Member

Fixed by @jolelievre & @atomiix and tested by @khouloudbelguith

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@atomiix atomiix

@jolelievre jolelievre

Labels
8.0.x Branch Autoupgrade Module: autoupgrade BO Category: Back Office Bug Type: Bug Fixed Resolution: issue closed because fixed Major Severity: major bug > https://build.prestashop.com/news/severity-classification Module Module PR available Solution: issue is being addressed Regression Type: regression Verified The issue has been reproduced
Projects
None yet
Milestone
8.0.0
7 participants
@eternoendless @Progi1984 @atomiix @jolelievre @hibatallahAouadni @MatShir @marwachelly