Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use anyio.abc types with full namespace instead of from imports #6753

Closed
3 tasks done
zanieb opened this issue Sep 8, 2022 · 1 comment · Fixed by #6784
Closed
3 tasks done

Use anyio.abc types with full namespace instead of from imports #6753

zanieb opened this issue Sep 8, 2022 · 1 comment · Fixed by #6784
Labels
development Tech debt, refactors, CI, tests, and other related work. good first issue This issue is good for newcomers

Comments

@zanieb
Copy link
Contributor

zanieb commented Sep 8, 2022

First check

  • I added a descriptive title to this issue.
  • I used the GitHub search to find a similar request and didn't find it.
  • I searched the Prefect documentation for this feature.

Prefect Version

2.x

Describe the current behavior

Currently we import types from anyio with

from anyio.abc import TaskStatus, ...

Describe the proposed behavior

Often these types names overlap with Prefect concepts e.g. tasks. It'd be clearer to use:

import anyio.abc

Then use the full name to reference it later e.g. anyio.abc.TaskStatus

Example Use

This is an internal improvement.

Additional context

No response

@zanieb zanieb added good first issue This issue is good for newcomers development Tech debt, refactors, CI, tests, and other related work. status:backlog labels Sep 8, 2022
@zanieb zanieb changed the title Use anyio.abc types with full namespace instead of relative Use anyio.abc types with full namespace instead of relative imports Sep 8, 2022
@zanieb zanieb changed the title Use anyio.abc types with full namespace instead of relative imports Use anyio.abc types with full namespace instead of from imports Sep 8, 2022
@shraddhafalane
Copy link
Contributor

Would like to take this up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development Tech debt, refactors, CI, tests, and other related work. good first issue This issue is good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants