Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

boto3 client use_ssl wrong default #327

Closed
1 task done
j-tr opened this issue Oct 24, 2023 · 0 comments · Fixed by #328
Closed
1 task done

boto3 client use_ssl wrong default #327

j-tr opened this issue Oct 24, 2023 · 0 comments · Fixed by #328

Comments

@j-tr
Copy link
Contributor

j-tr commented Oct 24, 2023

Regression from 0.4.0 to 0.4.1 due to #322.

A push_to_s3 step on v0.4.0 will successfully upload to a SSL only S3 bucket.

on v0.4.1 it fails with

raise S3UploadFailedError(
boto3.exceptions.S3UploadFailedError: Failed to upload <...>/flow.py: An error occurred (AccessDenied) when calling the PutObject operation: Access Denied

This is most likely due to the use_ssl parameter default None in https://github.com/PrefectHQ/prefect-aws/blob/c4939d76c8868c98a187fad47da4a09c1e11121f/prefect_aws/deployments/steps.py#L223C5-L223C12 which contradicts the boto3 client default 'True' https://boto3.amazonaws.com/v1/documentation/api/latest/reference/core/session.html#boto3.session.Session.client

@j-tr j-tr changed the title use AWS credentials from env variables boto3 client use_ssl wrong default Oct 24, 2023
@j-tr j-tr mentioned this issue Oct 24, 2023
5 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant