Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option for the first day of the week #54

Closed
Namnodorel opened this issue Apr 18, 2021 · 5 comments
Closed

Option for the first day of the week #54

Namnodorel opened this issue Apr 18, 2021 · 5 comments
Labels
enhancement New feature or request

Comments

@Namnodorel
Copy link

I've had testers request an option to pick which day is supposed to be the first day of the week in the datepicker. Since that's currently not possible afaik, I would like to request making it an (optional) argument for the date picker.

@PranavMaganti
Copy link
Owner

Sorry, not quite sure I fully understand the request. Would this just be an argument in the datepicker which take in a day such as Monday, Tuesday, etc. and then set up the date picker to show that day's column to be the first on in the calendar view?

@Namnodorel
Copy link
Author

Namnodorel commented Apr 18, 2021

Yes, precisely.

It may be an alternative to set the first day of the week based on locale, but I'm not sure whether there is an API to check that conveniently.

@PranavMaganti PranavMaganti added the enhancement New feature or request label Apr 21, 2021
@PranavMaganti
Copy link
Owner

Doesn't seem like there's any way to do this from the locale so I'll just make it a parameter for now. I'm currently working on a couple of other features on the date picker so I'll try and get this implemented after those are done which should be soon.

@kalinjul
Copy link

kalinjul commented Mar 2, 2022

Here's my PR to make first day of week locale based:
#135

@PranavMaganti
Copy link
Owner

The first day is now set based on device locale and can be modified using a parameter as of 0.7.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants