MSFT_xWindowsProcess.psm1: Fix Script Analyzer Issues

[mhendric]

Details of the scenario you tried and the problem that is occurring

There's a number of script analyzer issues getting reported in MSFT_xWindowsProcess.psm1. These should be fixed.

Verbose logs showing the problem

[00:05:07]     Context MSFT_xWindowsProcess.psm1
[00:05:07]       [+] Should pass all error-level PS Script Analyzer rules 150ms
[00:05:10]       [+] Should pass all required PS Script Analyzer rules 2.92s
[00:05:10]       [+] Should pass all flagged PS Script Analyzer rules 497ms
[00:05:10]       [+] Should pass any recently-added, error-level PS Script Analyzer rules 57ms
[00:05:12]       [+] Should not suppress any required PS Script Analyzer rules 1.45s
[00:05:13] Custom DSC Resource Kit PSSA rule(s) did not pass.
[00:05:13] The following PSScriptAnalyzer rule 'DscResource.AnalyzerRules\Measure-FunctionBlockBraces' errors need to be fixed:
[00:05:13] MSFT_xWindowsProcess.psm1 (Line 1104): Opening brace on function should be followed by a new line. See https://github.com/PowerShell/DscResources/blob/master/StyleGuidelines.md#one-newline-after-opening-brace
[00:05:13] The following PSScriptAnalyzer rule 'DscResource.AnalyzerRules\Measure-IfStatement' errors need to be fixed:
[00:05:13] MSFT_xWindowsProcess.psm1 (Line 582): Opening brace on if-statements should only be followed by one new line. See https://github.com/PowerShell/DscResources/blob/master/StyleGuidelines.md#one-newline-after-opening-brace
[00:05:13] The following PSScriptAnalyzer rule 'DscResource.AnalyzerRules\Measure-ParameterBlockParameterAttribute' errors need to be fixed:
[00:05:13] MSFT_xWindowsProcess.psm1 (Line 47): A [Parameter()] attribute must be the first attribute of each parameter and be on its own line. See https://github.com/PowerShell/DscResources/blob/master/StyleGuidelines.md#correct-format-for-parameter-block
[00:05:13] MSFT_xWindowsProcess.psm1 (Line 160): A [Parameter()] attribute must be the first attribute of each parameter and be on its own line. See https://github.com/PowerShell/DscResources/blob/master/StyleGuidelines.md#correct-format-for-parameter-block
[00:05:13] MSFT_xWindowsProcess.psm1 (Line 165): A [Parameter()] attribute must be the first attribute of each parameter and be on its own line. See https://github.com/PowerShell/DscResources/blob/master/StyleGuidelines.md#correct-format-for-parameter-block
[00:05:13] MSFT_xWindowsProcess.psm1 (Line 169): A [Parameter()] attribute must be the first attribute of each parameter and be on its own line. See https://github.com/PowerShell/DscResources/blob/master/StyleGuidelines.md#correct-format-for-parameter-block
[00:05:13] MSFT_xWindowsProcess.psm1 (Line 172): A [Parameter()] attribute must be the first attribute of each parameter and be on its own line. See https://github.com/PowerShell/DscResources/blob/master/StyleGuidelines.md#correct-format-for-parameter-block
[00:05:13] MSFT_xWindowsProcess.psm1 (Line 175): A [Parameter()] attribute must be the first attribute of each parameter and be on its own line. See https://github.com/PowerShell/DscResources/blob/master/StyleGuidelines.md#correct-format-for-parameter-block
[00:05:13] MSFT_xWindowsProcess.psm1 (Line 178): A [Parameter()] attribute must be the first attribute of each parameter and be on its own line. See https://github.com/PowerShell/DscResources/blob/master/StyleGuidelines.md#correct-format-for-parameter-block
[00:05:13] MSFT_xWindowsProcess.psm1 (Line 437): A [Parameter()] attribute must be the first attribute of each parameter and be on its own line. See https://github.com/PowerShell/DscResources/blob/master/StyleGuidelines.md#correct-format-for-parameter-block
[00:05:13] MSFT_xWindowsProcess.psm1 (Line 442): A [Parameter()] attribute must be the first attribute of each parameter and be on its own line. See https://github.com/PowerShell/DscResources/blob/master/StyleGuidelines.md#correct-format-for-parameter-block
[00:05:13] MSFT_xWindowsProcess.psm1 (Line 446): A [Parameter()] attribute must be the first attribute of each parameter and be on its own line. See https://github.com/PowerShell/DscResources/blob/master/StyleGuidelines.md#correct-format-for-parameter-block
[00:05:13] MSFT_xWindowsProcess.psm1 (Line 449): A [Parameter()] attribute must be the first attribute of each parameter and be on its own line. See https://github.com/PowerShell/DscResources/blob/master/StyleGuidelines.md#correct-format-for-parameter-block
[00:05:13] MSFT_xWindowsProcess.psm1 (Line 452): A [Parameter()] attribute must be the first attribute of each parameter and be on its own line. See https://github.com/PowerShell/DscResources/blob/master/StyleGuidelines.md#correct-format-for-parameter-block
[00:05:13] MSFT_xWindowsProcess.psm1 (Line 455): A [Parameter()] attribute must be the first attribute of each parameter and be on its own line. See https://github.com/PowerShell/DscResources/blob/master/StyleGuidelines.md#correct-format-for-parameter-block
[00:05:13] MSFT_xWindowsProcess.psm1 (Line 563): A [Parameter()] attribute must be the first attribute of each parameter and be on its own line. See https://github.com/PowerShell/DscResources/blob/master/StyleGuidelines.md#correct-format-for-parameter-block
[00:05:13] MSFT_xWindowsProcess.psm1 (Line 566): A [Parameter()] attribute must be the first attribute of each parameter and be on its own line. See https://github.com/PowerShell/DscResources/blob/master/StyleGuidelines.md#correct-format-for-parameter-block
[00:05:13] MSFT_xWindowsProcess.psm1 (Line 571): A [Parameter()] attribute must be the first attribute of each parameter and be on its own line. See https://github.com/PowerShell/DscResources/blob/master/StyleGuidelines.md#correct-format-for-parameter-block
[00:05:13] MSFT_xWindowsProcess.psm1 (Line 749): A [Parameter()] attribute must be the first attribute of each parameter and be on its own line. See https://github.com/PowerShell/DscResources/blob/master/StyleGuidelines.md#correct-format-for-parameter-block
[00:05:13] MSFT_xWindowsProcess.psm1 (Line 845): A [Parameter()] attribute must be the first attribute of each parameter and be on its own line. See https://github.com/PowerShell/DscResources/blob/master/StyleGuidelines.md#correct-format-for-parameter-block
[00:05:13] For instructions on how to run PSScriptAnalyzer on your own machine, please go to https://github.com/powershell/PSScriptAnalyzer
[00:05:13] Common Tests - Custom Script Analyzer Rules will not fail unless you opt-in.
[00:05:13] To opt-in, create a '.MetaTestOptIn.json' at the root
[00:05:13] of the repo in the following format:
[00:05:13] [
[00:05:13]      "Common Tests - Custom Script Analyzer Rules"
[00:05:13] ]
[00:05:13]       [+] Should pass all custom DSC Resource Kit PSSA rules 831ms

Version of the DSC module that was used ('dev' if using current dev branch)

dev

[PlagueHO]

Picking this one up!