Error with xArchive when file names contain brackets.

[bielawb]

In certain scenarios xArchive will fail. It seems to show up only in set certain scenarios:
-- zip file has a name that contains bracket
-- one of the files in the zip contains bracket, but most files are synced already (e.g. if file in question was removed).

Repro:

configuration BracketsInZip {
    Import-DscResource -ModuleName @{ 
        ModuleName = 'xPSDesiredStateConfiguration'
        RequiredVersion = '4.0.0.0' 
    }
    xArchive test {
        Path = 'C:\temp\testZip[.zip'
        Destination = 'C:\temp\TestWithBracket'
    }

}

configuration BracketsInsideZip {
    Import-DscResource -ModuleName @{ 
        ModuleName = 'xPSDesiredStateConfiguration'
        RequiredVersion = '4.0.0.0' 
    }
    xArchive test {
        Path = 'C:\temp\testZip.zip'
        Destination = 'C:\temp\TestWithBracket'
    }

}

# Testing zip file with odd name...
BracketsInZip -OutputPath c:\temp\bracket
Start-DscConfiguration -Path c:\temp\bracket -Wait -Verbose

# Error message...
PowerShell DSC resource MSFT_xArchive  failed to execute Test-TargetResource functionality with error message: The specified wildcard character pattern is not valid: testZip[.zip 


# Testing zip file that contains files with odd name...
BracketsInsideZip -OutputPath c:\temp\bracket
Start-DscConfiguration -Path c:\temp\bracket -Wait -Verbose -Force

# Error message...
VERBOSE: [ASUS]:                            [[xArchive]test] Writing to file C:\temp\TestWithBracket\testZip\testFile[
VERBOSE: [ASUS]: LCM:  [ End    Set      ]  [[xArchive]test]  in 0.1300 seconds.
PowerShell DSC resource MSFT_xArchive  failed to execute Set-TargetResource functionality with error message: Cannot retrieve the dynamic parameters for the cmdlet. The specified wildcard 
character pattern is not valid: testFile[ 

The fix: use -LiteralPath whenever possible. -Path assumes wildcards and shouldn't be used as individual files (rather than wildcards) are expected as input to any cmdlet called.