Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discussion: Deprecate RunCode Feature #4892

Closed
2 tasks done
JustinGrote opened this issue Jan 17, 2024 · 1 comment · Fixed by #4893
Closed
2 tasks done

Discussion: Deprecate RunCode Feature #4892

JustinGrote opened this issue Jan 17, 2024 · 1 comment · Fixed by #4893
Assignees
Labels
Area-Engine Issue-Enhancement A feature request (enhancement).

Comments

@JustinGrote
Copy link
Collaborator

Prerequisites

  • I have written a descriptive issue title.
  • I have searched all issues to ensure it has not already been reported.

Summary

The RunCode feature was added 5 years ago by @TylerLeonhardt to support the related codelens feature at the time, but now all codelens is driven via PSES, so this command is never used anywhere in the codebase, and is exposed as a command with no keybinding that, when bound to a key, executes with no arguments and basically crashes because all the parameters it requires are undefined.

Proposed Design

Either completely remove the library or stub out the command with a warning that it is no longer supported.

@JustinGrote JustinGrote added Issue-Enhancement A feature request (enhancement). Needs: Triage Maintainer attention needed! labels Jan 17, 2024
@JustinGrote JustinGrote self-assigned this Jan 17, 2024
@andyleejordan
Copy link
Member

Lol of course, let's delete it!

@SydneyhSmith SydneyhSmith added Area-Engine and removed Needs: Triage Maintainer attention needed! labels Jan 17, 2024
@SydneyhSmith SydneyhSmith moved this to In Progress in Flying Fox Jan 17, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Flying Fox Jan 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Engine Issue-Enhancement A feature request (enhancement).
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants