Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "Get Help for Command" #4212

Closed
6 tasks done
andyleejordan opened this issue Oct 19, 2022 · 0 comments · Fixed by PowerShell/PowerShellEditorServices#1970
Closed
6 tasks done

Fix "Get Help for Command" #4212

andyleejordan opened this issue Oct 19, 2022 · 0 comments · Fixed by PowerShell/PowerShellEditorServices#1970
Assignees
Labels
Area-UI Issue-Bug A bug to squash.

Comments

@andyleejordan
Copy link
Member

Prerequisites

  • I have written a descriptive issue title.
  • I have searched all open and closed issues to ensure it has not already been reported.
  • I have read the troubleshooting guide.
  • I am sure this issue is with the extension itself and does not reproduce in a standalone PowerShell instance.
  • I have verified that I am using the latest version of Visual Studio Code and the PowerShell extension.
  • If this is a security issue, I have read the security issue reporting guidance.

Summary

The client command 'Get Help for Command' AKA PowerShell.ShowHelp does not appear to work correctly. The server responds with a URI, which is not shown in the extension terminal, and nothing happens in the client until you hit enter in the terminal, at which point the URI is opened in the browser.

The server's handler script is a bit funky and has a to-do that says "rather than print the help in the console, we should send the string back to VSCode to display in a help pop-up (or similar)." So let's do that!

FWIW PowerShell.OnlineHelp is marked deprecated and at this point should be removed.

PowerShell Version

N/A

Visual Studio Code Version

N/A

Extension Version

N/A

Steps to Reproduce

N/A

Visuals

No response

Logs

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-UI Issue-Bug A bug to squash.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant