Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output window only opens first time run selection (F8) is used #217

Closed
jimbrownthrowaway opened this issue Jul 4, 2016 · 4 comments
Closed
Labels
Issue-Enhancement A feature request (enhancement).
Milestone

Comments

@jimbrownthrowaway
Copy link

jimbrownthrowaway commented Jul 4, 2016

Extremely new to using both VS Code and the PowerShell Extension so please forgive me if I'm missing something obvious or if this shouldn't even be filed as an issue.

When you use F8 to run a selection of code the first time you do it the output window opens to show the results. If you then close the output window and use F8 again it doesn't open the output window again, if you open it manually it shows the output. I thought that the F8 command wasn't working at first because it was no longer opening the window so I didn't know it was actually executing the code.

I'm using VS Code 1.2.1 and PowerShell Extension 0.6.1 on Windows 10

@daviwil
Copy link
Contributor

daviwil commented Jul 7, 2016

Yeah, the assumption I made here is that if the window had been auto-opened the first time and the user manually closed it, then it might get annoying if we auto reopen it each time output gets written. I'm hoping to avoid this problem entirely in the near future by removing the current Run Selection functionality in favor of using the new integrated terminal for an ISE-like interactive experience.

@rkeithhill
Copy link
Contributor

ISE will make the console pane visible on pressing F8, if it is not visible. If "run selection" runs in the terminal window, and the terminal window is closed, the terminal window would be opened by the extension, right? I think folks would expect that.

@daviwil
Copy link
Contributor

daviwil commented Jul 13, 2016

Good point, Keith. The correct trigger for opening the window should be the invocation of Run Selection rather than just from receiving output.

@daviwil daviwil added this to the Backlog milestone Jul 13, 2016
@daviwil daviwil added the Issue-Enhancement A feature request (enhancement). label Jul 13, 2016
@daviwil daviwil modified the milestones: 0.7.3, Backlog Sep 8, 2016
@daviwil
Copy link
Contributor

daviwil commented Sep 12, 2016

Moving this to 0.8.0 because I might be able to get rid of it entirely if the new integrated terminal approach (#293) works out!

@daviwil daviwil modified the milestones: 0.8.0, 0.7.3 Sep 12, 2016
@daviwil daviwil closed this as completed in f596896 Dec 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Enhancement A feature request (enhancement).
Projects
None yet
Development

No branches or pull requests

3 participants