-
Notifications
You must be signed in to change notification settings - Fork 484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve syntax coloring definition to meet the standards of PowerShell ISE, Visual Studio #199
Comments
Hey Pavan, the problems you see with VS Code's syntax highlighting for PowerShell come from the TextMate syntax definition we borrowed from Sublime Text which is based purely on regular expressions. We won't be able to keep 100% consistency with Visual Studio and the PowerShell ISE because VS Code does not allow us to implement a custom classifier based on the PowerShell parser. That said, we need to improve the syntax definition to be more consistent with what users expect. We've got a plan to take over maintenance of the TextMate syntax definition that we use so that we can improve the quality of its colorization, it just may take a little while before we get to it. |
I'd love to help out with this one @daviwil. |
That'd be fantastic! Would love some help on that. I need to create a GitHub repo for the common syntax coloring definition used across VS Code, Sublime Text and Atom. I'll get that started today. |
Nice, let me know when you have it set up and I'll start taking a look at it. :) |
Excellent, lets do it! |
I compare VSCode coloring with Visual studio with different themes and observed that the cmdlet, parameter name and values are not following correct pattern.
Actual:
Exp: In the below screenshot you can see -class and -computer is displaying in different color and Win32_OperatingSystem and localhost are displaying in different color.
Expected: Cmdlet, parameter and value should be display in three different colors and should be consistent in the script file same like visual studio.
The text was updated successfully, but these errors were encountered: