Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve syntax coloring definition to meet the standards of PowerShell ISE, Visual Studio #199

Closed
v-pavanp opened this issue May 23, 2016 · 5 comments
Labels
Issue-Enhancement A feature request (enhancement).

Comments

@v-pavanp
Copy link

v-pavanp commented May 23, 2016

I compare VSCode coloring with Visual studio with different themes and observed that the cmdlet, parameter name and values are not following correct pattern.
Actual:

  1. With Light (Visual Studio) and Dark+ (Default Dark) themes the PS comdlet , parameter and parameter value are displaying in the same color.

vslighttheme

  1. When multiple parameters are provide with the command then they are displaying in the different color.
    Exp: In the below screenshot you can see -class and -computer is displaying in different color and Win32_OperatingSystem and localhost are displaying in different color.
    image
    Expected: Cmdlet, parameter and value should be display in three different colors and should be consistent in the script file same like visual studio.
    image
@daviwil
Copy link
Contributor

daviwil commented May 23, 2016

Hey Pavan, the problems you see with VS Code's syntax highlighting for PowerShell come from the TextMate syntax definition we borrowed from Sublime Text which is based purely on regular expressions. We won't be able to keep 100% consistency with Visual Studio and the PowerShell ISE because VS Code does not allow us to implement a custom classifier based on the PowerShell parser.

That said, we need to improve the syntax definition to be more consistent with what users expect. We've got a plan to take over maintenance of the TextMate syntax definition that we use so that we can improve the quality of its colorization, it just may take a little while before we get to it.

@daviwil daviwil added the Issue-Enhancement A feature request (enhancement). label May 23, 2016
@daviwil daviwil added this to the Backlog milestone May 23, 2016
@daviwil daviwil changed the title Coloring format is messed up with different VScode theme for PS cmdlets, parameter name and value. Improve syntax coloring definition to meet the standards of PowerShell ISE, Visual Studio May 23, 2016
@gravejester
Copy link

I'd love to help out with this one @daviwil.

@daviwil
Copy link
Contributor

daviwil commented May 24, 2016

That'd be fantastic! Would love some help on that. I need to create a GitHub repo for the common syntax coloring definition used across VS Code, Sublime Text and Atom. I'll get that started today.

@gravejester
Copy link

Nice, let me know when you have it set up and I'll start taking a look at it. :)

@vors
Copy link
Contributor

vors commented May 24, 2016

Excellent, lets do it!
For sublime side of things see SublimeText/PowerShell#148

@daviwil daviwil modified the milestone: Backlog May 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Enhancement A feature request (enhancement).
Projects
None yet
Development

No branches or pull requests

4 participants