Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Characters such as M-dashes and smart quotes should be replaced #127

Closed
TimShererAtAquent opened this issue Jun 7, 2016 · 2 comments
Closed
Assignees
Milestone

Comments

@TimShererAtAquent
Copy link

This is a feature request.

I don’t have a lot of examples – see ForEach-Object InputObject param:

“command results to ForEach-Object, the InputObject value—even if the value is a collection that is the result of a command, such as –InputObject (Get-Process)—is”

Here’s the preview mode of atom:

“Object value—even if the value is a collection that is the result of a command, such as –InputObject (Get”

This is probably what it looks like in the console (I don’t have this version of PS installed.)

We should replace em dashes and en dashes with hyphens. So, asci 150 and 151.

While I have the ascii table out. These should be a simple apostrophe:

145 91 ‘ ‘
146 92 ’ ’

These should be straight quotes.

147 93 “ “
148 94 ” ”

Like I said, I don't have a lot of examples because we set Dx not to use these characters, but there will be lots of text editors used and lots of copy paste as we do round tripping.

Let me know if this has been dealt with - I don't see it in the resolved issues.

@vors vors self-assigned this Jun 8, 2016
@vors vors added this to the 0.5.0 milestone Jun 8, 2016
@vors
Copy link
Collaborator

vors commented Jun 12, 2016

Implementation note: C# and PS uses Unicode, not ASCII

So left single quote would be 0x2018, not 0x91
http://www.fileformat.info/info/unicode/char/2018/index.htm

@vors
Copy link
Collaborator

vors commented Jun 12, 2016

Fixed per 12f56fb

@vors vors closed this as completed Jun 12, 2016
@vors vors removed the in progress label Jun 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants