Regression of 1545

[roblourens]

Prerequisites

• Write a descriptive title.
• Make sure you are able to repro it on the latest version
• Search the existing issues.

Steps to reproduce

In #1545, an issue was fixed with piping into ssh without a command, eg

$ echo "echo test" | ssh -T win64bot3
client_loop: send disconnect: Broken pipe

Downstream issue: microsoft/vscode-remote-release#7272 (comment)

I verified this as fixed in the 8.6 beta. In the issue above, it seems like the official 8.6 release actually has this issue. I haven't verified that myself. But I can verify it with the 8.9 beta from the releases page.

Expected behavior

It should echo "test"

Actual behavior

Now it fails with `client_loop: send disconnect: Broken pipe`

Error details

Environment data

PS C:\Users\roblou> $PSVersionTable

Name                           Value
----                           -----
PSVersion                      5.1.19041.1320
PSEdition                      Desktop
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
BuildVersion                   10.0.19041.1320
CLRVersion                     4.0.30319.42000
WSManStackVersion              3.0
PSRemotingProtocolVersion      2.3
SerializationVersion           1.1.0.1

### Version

8.9.1.0-beta

### Visuals

_No response_

[PaulHigin]

I cannot repro this in the latest builds. But in addition, I feel the repro steps above are incorrect. As pointed out in the original issue (#1545 (comment)), you need to specify the command on the server that accepts the piped input.

echo "test" | ssh win64bot3 pwsh
PS C:\ > "test"
test

[roblourens]

What does "latest builds" mean, what version exactly?

The original issue was about how it should work without specifying the command. Specifying the command is a workaround. This is an important scenario for vscode's Remote-SSH extension.

[PaulHigin]

I was testing v8.9 and v9.1, but I see that the original fix went in v8.6 and it worked there. So this does look like a regression.

[vthiebaut10]

Regression will be fixed on the next release (v9.1).

[roblourens]

Thank you!

[roblourens]

Do you know what the timeline is like for 9.1 reaching users via Windows Update?

[PaulHigin]

This was fixed with this PR (null ptr check): PowerShell/openssh-portable#616

[roblourens]

Thanks, but do you know when it will reach Windows users?

[vthiebaut10]

@roblourens It takes a number of months to ship the newer versions of OpenSSH to Windows. But you can get the beta version from the Releases page in this repo once we release it and install it using the instructions from our Wiki.

[roblourens]

I understand that it takes a number of months- the last time I reported a bug in this project, it took over a year. So I'm wondering whether you have a sense of what the timeline for the next release is like or is it to early to know?

[maertendMSFT]

Unfortunately, we cannot comment on Windows release timelines. Our latest beta bits will always ship on GitHub and our in-box version be included in a Windows release at a later date.