Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limit history to successful commands #4065

Open
1 task done
fflaten opened this issue Jul 8, 2024 · 0 comments
Open
1 task done

Limit history to successful commands #4065

fflaten opened this issue Jul 8, 2024 · 0 comments
Labels
Issue-Enhancement It's a feature request. Needs-Triage 🔍 It's a new issue that core contributor team needs to triage.

Comments

@fflaten
Copy link

fflaten commented Jul 8, 2024

Prerequisites

  • Write a descriptive title.

Description of the new feature/enhancement

Can PSReadLine ignore commands that failed? It's mostly noise and bad suggestions for the predictor.

The predictor has been bullying me with a typo (build.ps1 instead of .\build.ps1) for a few weeks now until I manually edited my history file. 😆

Proposed technical implementation details (optional)

Check $? before committing to history? Will need to reset $? to original value after checking, similar to VSCode shell integration (possible conflict?)
@fflaten fflaten added the Issue-Enhancement It's a feature request. label Jul 8, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Triage 🔍 It's a new issue that core contributor team needs to triage. label Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Issue-Enhancement It's a feature request. Needs-Triage 🔍 It's a new issue that core contributor team needs to triage.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fflaten