Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle when file in pgrst.jwt_secret does not exist #3634

Closed
wants to merge 1 commit into from
Closed

fix: handle when file in pgrst.jwt_secret does not exist #3634

wants to merge 1 commit into from

Conversation

laurenceisla
Copy link
Member

Closes #3629

  • PostgREST now starts/reloads config correctly with old jwt-secret
  • The error is logged to stderr

@laurenceisla
fix: handle when file in pgrst.jwt_secret does not exist
2dd56f3 
- PostgREST now starts/reloads correctly with old jwt-secret
- The error is logged to stderr
@laurenceisla laurenceisla marked this pull request as ready for review July 2, 2024 13:10
@steve-chavez
Copy link
Member

🤔 Hm, it doesn't make sense to refer to a file in the in-db config right?

I guess being consistent and no silent fail is still good though.

@laurenceisla
Copy link
Member Author

🤔 Hm, it doesn't make sense to refer to a file in the in-db config right?

Ah, got it.

I guess being consistent and no silent fail is still good though.

I'll add this in #3628, then. Since handling the issue is now more relevant there.

@laurenceisla laurenceisla deleted the fix-db-err-hang branch July 2, 2024 17:35
This was referenced Jul 2, 2024
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The pgrst.jwt_secret in-database configuration should not interpret a file path
2 participants
@laurenceisla @steve-chavez