Change directive() function to wrap the entire directive factory. #562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinfagnani
force-pushed
the
directive-fn
branch
from
191e251
to
1fa8d92
Compare
sorvell
approved these changes
Oct 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change lets us abstract over directive arguments in the future if we need to, which might offer a way to build directive state management into lit's core, rather than forcing directives to use WeakMaps keyed off Parts.
In the meantime, it's a no-op in terms of functionality, though I think it looks a marginally nicer to write directives.
This is a smaller change than converting directives to classes, which I did in https://github.com/Polymer/lit-html/compare/directives