-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gtk-rs GTK3 bindings - no longer maintained #227
Comments
Oh, finally, a good excuse to remove the GTK backend 😄 On a more serious note, GTK3 backend is already optional, non-default and unrecommended, so I believe it is fine to depend on gtk-sys for it. |
Ok I understand. I'm sorry to hear that though as that's what I use on Ubuntu. If I'm able to manage the time and can replace it with the new version would you be open to a PR? |
Including the other advisory numbers here in case anyone is searching for them.
|
This will prevent all projects that are still on GTK3 (like Tauri) from updating RFD, as having GTK3 and 4 in the same binary will cause linking problems. So it would have to be yet another separate backend. And on top of that the update will not be trivial, the current GTK3 backend is a terrible hack that is attempting to hide away the fact that GTK is a full-blown UI toolkit (that loves to store stuff in random globals, so using it in multithreaded context is nightmare) rather than a file dialog API. So to answer your question, if the GTK4 backend ends up being as hacky as GTK3 one, then I would just prefer to drop it in favor of proper XDG API. If GTK4 backend in contrast to 3 ends up being a sane solution, then sure we can merge it and live happily ever after. |
Thank you very much for the explanation. I honestly don't know if it's worth it for me. I use egui most of the time and for native applications (compared to WASM) there is a really great project that I like and I might just go with that instead. Or try to see if the XDG backend works for me. I 100% agree that if GTK 4 needs to be a hack it's not worth going down that road. I didn't know how hard the upgrade would be why I was considering it but I have a lot on my plate right now and wasn't even sure how I was going to fit this in when I thought it might be easy. |
Hi,
Thank you very much for the work done on this crate. cargo-deny brought it to my attention that the
gtk-sys
crate that this crate depends on is no longer maintained as per their repo. I tried searching to see if there was already an issue here but I couldn't find one. The details of the security advisory follows:The text was updated successfully, but these errors were encountered: