Skip to content
This repository has been archived by the owner on Jul 29, 2024. It is now read-only.

Chokes on a package dependency which can't be found but has just been installed #58

Closed
jwg4 opened this issue Dec 15, 2015 · 6 comments
Closed
Labels

Comments

@jwg4
Copy link
Contributor

jwg4 commented Dec 15, 2015

Hi there, thanks for this great tool.

If I have a requirements.txt which contains two packages, and one of them is a URL of a download which isn't on pypi:

http://internal/packages/bar_1-0.tar.gz
foo=1.0

Installing these requirements into a virtualenv using Terrarium fails, it seems because:
If foo has a dependency on bar, then installing foo will fail because it doesn't know how to find the package bar, even though it has just been installed from the URL.

By contrast, pip will realize that bar is already present, and not worry about finding it.

@winhamwr winhamwr added the bug label Dec 15, 2015
@winhamwr
Copy link
Contributor

Hi jwg4,

Thanks for creating an issue!

To clarify, you see this behavior when creating a virtualenv from scratch, right? So it sounds like maybe this has something to do with packages distributed outside of pypi via tarballs, perhaps?

here is the command that terrarium uses to run pip. Perhaps one of the options modifies the behavior that you normally see?

To maximize the chance of getting a fix for this merged in, would you be willing to create a failing testcase? this test is a good place to start. Basically, it sounds you'll want to self._add_requirements(...) to',add a tarball requirement and then again to add a requirement for a package that depends on that tarball.

Thanks
-Wes

@jwg4
Copy link
Contributor Author

jwg4 commented Dec 16, 2015

I have done the second task of creating a test case, in #59 Let me know if there are any queries or changes required.
I haven't yet been able to figure out where the invocation of pip differs to what one would normally do as a pip user. I will look at this a bit more.

@jwg4
Copy link
Contributor Author

jwg4 commented Jan 11, 2016

#59 now has a fix as well as a test case.

@jwg4
Copy link
Contributor Author

jwg4 commented Dec 30, 2016

This fix is a year old. Terrarium was a great concept, but you should warn people in the README and the docs that it is unmaintained.

@jlward
Copy link
Contributor

jlward commented Jan 3, 2017

Hello jwg4

Sorry we haven't had a chance to look into this in the past year. The reason we are sorting the reqs is so that if all you have done is re-order the reqs in requirements.txt file, the generated hash is not different. #59 will fix the bug outlined in this issue, while also breaking the hash if the order is the only thing that has changed. I have reached out to the other devs for this project and hopefully one of them will be weigh in with determining if breaking the hash is alright. Thanks so much for the PR and sorry if it seems we are not maintaining this project. We will try to be better about PRs in the future.

Jason

@kylegibson
Copy link
Member

#59 was merged in

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants