This repository has been archived by the owner on Jul 29, 2024. It is now read-only.
Pip 1.2 compatibility #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you merge up with master and push again? Thanks |
|
This may not actually install svn repository requirements correctly. Or at least, that's what seemed to have happened when using it on some of our test servers. Not sure why yet, still working on it. Also, I'm still unable to get the tests passing with or without this change, but it's probably just something silly. |
|
Looks like you pushed commits for the other pull request to the same branch as this pull request. |
|
I would have to delete the pull request and do another one from a branch containing just this change. Would you like me to do that? |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't fully understand the system pip uses, but it appears that in versions later than 1.2, calling pip.version_control() is unnecessary, because that functionality is included by default.
Here is the relevant pip commit where version_control was removed: pypa/pip@56dc836