This repository has been archived by the owner on Jan 5, 2024. It is now read-only.
feat(list): list seeder #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kschelonka
force-pushed
the
INFRA-311/feat/seed-list
branch
from
2344af2 to
6236284
Compare
Herraj
reviewed
Mar 1, 2022
| const isFavorite = Math.random() < favoriteRate; | ||
| const isArticle = Math.random() < articleRate; // otherwise video | ||
|
|
||
| listData[index % batchSize] = { |
There was a problem hiding this comment.
Correct me if I'm wrong, we insert items in this listData array from index 0 --> 100 (batch size), yield that listData and then start again?
There was a problem hiding this comment.
yep, and it reuses the same array hence the modulo indexing. Using a generator keeps us from accidentally making massive datasets that make your computer run out of memory
add test assertion
Herraj
approved these changes
Mar 1, 2022
|
🎉 This PR is included in version 1.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Seed some configurable benchmarking data that is somewhat realistic.
References
Issues:
Implementation Decisions