Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from Data.BigInt to JS.BigInt #1472

Closed
klntsky opened this issue Mar 30, 2023 · 3 comments
Closed

Switch from Data.BigInt to JS.BigInt #1472

klntsky opened this issue Mar 30, 2023 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@klntsky
Copy link
Member

klntsky commented Mar 30, 2023

@kozross kozross self-assigned this Oct 5, 2023
@kozross kozross added the enhancement New feature or request label Oct 5, 2023
@kozross
Copy link
Collaborator

kozross commented Oct 5, 2023

I don't think this is possible without a compiler upgrade. Even on 1.2.0 (which is a year old), I get the following:

[1/3 ModuleNotFound] .spago/js-bigints/a23c0ec1b3cb6c8468202221f51b162c2aa81516/src/Js/BigInt/BigInt.purs:23:1

  23  import Data.Reflectable (class Reflectable, reflectType)
      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  
  Module Data.Reflectable was not found.
  Make sure the source file exists, and that it has been provided as an input to the compiler.

This is a module that was introduced in a more recent version of Purescript than the one we run.

@klntsky
Copy link
Member Author

klntsky commented Oct 6, 2023

Sorry @kozross, forgot to mention it should be done on top of #1521

@klntsky
Copy link
Member Author

klntsky commented Dec 19, 2023

#1521

@klntsky klntsky closed this as completed Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

No branches or pull requests

2 participants