From ec87342e59aa71d6cb7ce73935a02f0549622f4e Mon Sep 17 00:00:00 2001 From: itamarw Date: Thu, 2 Jun 2022 16:06:01 +0300 Subject: [PATCH 1/2] added source field to json and added cy to readme --- README.md | 3 ++- dcollector/providers/aws.py | 4 +++- dcollector/providers/cycognito.py | 3 ++- dcollector/providers/digitalocean.py | 3 ++- dcollector/providers/gcp.py | 3 ++- dcollector/providers/prisma.py | 3 ++- 6 files changed, 13 insertions(+), 6 deletions(-) diff --git a/README.md b/README.md index d68969a..9e66acf 100644 --- a/README.md +++ b/README.md @@ -93,7 +93,7 @@ Short Form | Long Form | Description ## Output Example Output domains file will be in the following format (JSON): ```json -[{"name": "domain name", "record_type": "DNS type (CNAME,A)", "record_value": "value (ip,ec2 domain name)", "is_private": "false/true"}] +[{"name": "domain name", "record_type": "DNS type (CNAME,A)", "record_value": "value (ip,ec2 domain name)", "is_private": "false/true", "source": "provider/dns management tool"}] ``` ## Cloud Providers and Tools Support @@ -102,6 +102,7 @@ Output domains file will be in the following format (JSON): - GCP - Digital Ocean - Prisma® Cloud (by Palo Alto Networks) +- Cycognito (ASM product) --- ## Roadmap diff --git a/dcollector/providers/aws.py b/dcollector/providers/aws.py index df54a26..b88082f 100644 --- a/dcollector/providers/aws.py +++ b/dcollector/providers/aws.py @@ -92,7 +92,8 @@ def get_domains(): 'name': record['Name'].rstrip('.').replace('\\052.', '').replace('*.',''), 'record_type': record['Type'], 'record_value': '', - 'is_private': False + 'is_private': False, + 'source': 'aws' } if 'ResourceRecords' in record: @@ -104,6 +105,7 @@ def get_domains(): elif domain_data['record_type'] == 'CNAME': domain_data['is_private'] = utils.is_domain_internal(domain_data['record_value']) + domains.append(domain_data) except Exception as error: print('An error occurred while trying to get aws records:') diff --git a/dcollector/providers/cycognito.py b/dcollector/providers/cycognito.py index 41fde70..320e203 100644 --- a/dcollector/providers/cycognito.py +++ b/dcollector/providers/cycognito.py @@ -46,7 +46,8 @@ def get_domains(): 'name': asset['domain'].rstrip('.').replace('\\052.', '').replace('*.', ''), 'record_type': 'A', 'record_value': ip, - 'is_private': False + 'is_private': False, + 'source': 'cycognito' } domains.append(domain_data) return domains diff --git a/dcollector/providers/digitalocean.py b/dcollector/providers/digitalocean.py index 758886b..0a31703 100644 --- a/dcollector/providers/digitalocean.py +++ b/dcollector/providers/digitalocean.py @@ -37,7 +37,8 @@ def get_domains(): 'name': do_domain_name_normalise(r), 'record_type': r.type, 'record_value': r.data, - 'is_private': False + 'is_private': False, + 'source': 'digitalocean' } if domain_data['record_type'] == 'A': diff --git a/dcollector/providers/gcp.py b/dcollector/providers/gcp.py index 5e94d09..b564e24 100644 --- a/dcollector/providers/gcp.py +++ b/dcollector/providers/gcp.py @@ -49,7 +49,8 @@ def get_domains(): 'name': resource_record_set['name'].rstrip('.').replace('\\052.', '').replace('*.',''), 'record_type': resource_record_set['type'], 'record_value': resource_record_set['rrdatas'][0], - 'is_private': False + 'is_private': False, + 'source': 'gcp' } # Check if ip or domain name is private diff --git a/dcollector/providers/prisma.py b/dcollector/providers/prisma.py index 4124109..2436c75 100644 --- a/dcollector/providers/prisma.py +++ b/dcollector/providers/prisma.py @@ -102,7 +102,8 @@ def get_domains(): 'name': record['name'].rstrip('.').replace('\\052.', ''), 'record_type': record['type'], 'record_value': '', - 'is_private': False + 'is_private': False, + 'source': 'prisma' } if len(record['resourceRecords']): From fbd2d6eb75140c70f01784695c3ff010174dc97a Mon Sep 17 00:00:00 2001 From: rotemplay <54853320+rotemplay@users.noreply.github.com> Date: Wed, 8 Jun 2022 11:00:31 +0300 Subject: [PATCH 2/2] Fix a typo --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 9e66acf..c9dd8e7 100644 --- a/README.md +++ b/README.md @@ -102,7 +102,7 @@ Output domains file will be in the following format (JSON): - GCP - Digital Ocean - Prisma® Cloud (by Palo Alto Networks) -- Cycognito (ASM product) +- Cycognito (EASM product) --- ## Roadmap