From 6405c4103a6d9f1f7ca436c6faa7fcbd8ee6c91b Mon Sep 17 00:00:00 2001 From: Maharsh Patel <132877013+maharshpatel247@users.noreply.github.com> Date: Tue, 6 Jun 2023 20:55:02 +0530 Subject: [PATCH 1/2] SDK checks inconsistency resolved --- .../androidyoutubeplayer/core/player/utils/NetworkObserver.kt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/core/src/main/java/com/pierfrancescosoffritti/androidyoutubeplayer/core/player/utils/NetworkObserver.kt b/core/src/main/java/com/pierfrancescosoffritti/androidyoutubeplayer/core/player/utils/NetworkObserver.kt index f3f32491..d176265e 100644 --- a/core/src/main/java/com/pierfrancescosoffritti/androidyoutubeplayer/core/player/utils/NetworkObserver.kt +++ b/core/src/main/java/com/pierfrancescosoffritti/androidyoutubeplayer/core/player/utils/NetworkObserver.kt @@ -36,7 +36,7 @@ internal class NetworkObserver(private val context: Context) { /** Stop observing network changes and cleanup */ fun destroy() { - if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.LOLLIPOP) { + if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.N) { val callback = networkCallback ?: return val connectivityManager = context.getSystemService(Context.CONNECTIVITY_SERVICE) as ConnectivityManager connectivityManager.unregisterNetworkCallback(callback) From 8911c98913290c4267fd4b105465faa7deec6bd9 Mon Sep 17 00:00:00 2001 From: Maharsh Patel Date: Thu, 8 Jun 2023 10:43:46 +0530 Subject: [PATCH 2/2] Comment Added --- .../androidyoutubeplayer/core/player/utils/NetworkObserver.kt | 1 + 1 file changed, 1 insertion(+) diff --git a/core/src/main/java/com/pierfrancescosoffritti/androidyoutubeplayer/core/player/utils/NetworkObserver.kt b/core/src/main/java/com/pierfrancescosoffritti/androidyoutubeplayer/core/player/utils/NetworkObserver.kt index d176265e..e73bc712 100644 --- a/core/src/main/java/com/pierfrancescosoffritti/androidyoutubeplayer/core/player/utils/NetworkObserver.kt +++ b/core/src/main/java/com/pierfrancescosoffritti/androidyoutubeplayer/core/player/utils/NetworkObserver.kt @@ -36,6 +36,7 @@ internal class NetworkObserver(private val context: Context) { /** Stop observing network changes and cleanup */ fun destroy() { + // Min API for `unregisterNetworkCallback` is L, but we use `registerDefaultNetworkCallback` only for N and above. if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.N) { val callback = networkCallback ?: return val connectivityManager = context.getSystemService(Context.CONNECTIVITY_SERVICE) as ConnectivityManager