Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please make sure to confirm to standard cldf #17

Open
LinguList opened this issue Apr 9, 2017 · 3 comments
Open

Please make sure to confirm to standard cldf #17

LinguList opened this issue Apr 9, 2017 · 3 comments

Comments

@LinguList
Copy link
Collaborator

You currently have a strange feature to ignore sequences which start with a gap ("-") symbol. I suppose this is due to missing data. However, standard input format according to cldf is just removing these lines from the data, as is lingpy, since they are automatically computed as missing spots when converting the input files to internal language x concept matrices. It is only complicating the code if you allow for explicit missing data, and I do not see any need for this, so I suppose you adopt the more general format of just leaving these lines empty.

@Anaphory
Copy link
Collaborator

Anaphory commented Apr 9, 2017

Also, that feature cannot currently be deactivated. You can pass a string you expect not to appear in your CLDF, but you cannot actually tell it to remove any lines at all.

@Anaphory
Copy link
Collaborator

Anaphory commented Apr 9, 2017

Also, I just wanted to check what CLDF says about empty Value where Comment (or some other column) is present, but I could find no reference to Value outside the example Metadata in https://github.com/glottobank/cldf/blob/master/README.md, has that changed?

@LinguList
Copy link
Collaborator Author

Well, we now split in lexibank values into forms, and forms are the ultimate thing from which we convert to other values. Empty rows where value is none are usually always ignored, and they were always so in lingpy. The case of comment without value is unprecendented, but I suppose, if you have examples for that kind of data (which I don't have), that we port this issue to the cldf and discuss there with the others.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants