Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PowerPC wheel fails to compile #119

Closed
mlxd opened this issue Jul 28, 2021 · 2 comments
Closed

PowerPC wheel fails to compile #119

mlxd opened this issue Jul 28, 2021 · 2 comments
Labels
bug Something isn't working

Comments

@mlxd
Copy link
Member

mlxd commented Jul 28, 2021

Issue description

With the recent modifications to the repository, the wheel-builder for PowerPC (ppc64le) fails to compile the C++ modules.

  • Expected behavior: ppc64le wheels are successfully compiled.

  • Actual behavior: Wheel-builder fails to build ppc64le.

  • Reproduces how often: Always for PPC

Source code and tracebacks

Sample offending step:

|   gcc -pthread -Wno-unused-result -Wsign-compare -DNDEBUG -g -fwrapv -O3 -Wall -fPIC -DVERSION_INFO="0.16.0.dev0" -I/opt/_internal/cpython-3.7.10/lib/python3.7/site-packages/pybind11/include -I./include -I/opt/_internal/cpython-3.7.10/include/python3.7m -c pennylane_lightning/src/StateVector.cpp -o build/temp.linux-ppc64le-3.7/pennylane_lightning/src/StateVector.o -O3 -W -fPIC -shared -fopenmp -std=c++17 -fvisibility=hidden
|   In file included from pennylane_lightning/src/Gates.hpp:7:0,
|                    from pennylane_lightning/src/StateVector.hpp:33,
|                    from pennylane_lightning/src/StateVector.cpp:15:
|   pennylane_lightning/src/Util.hpp: In function ‘constexpr T Pennylane::Util::SQRT2()’:
|   pennylane_lightning/src/Util.hpp:90:8: error: expected ‘(’ before ‘constexpr’
|        if constexpr (std::is_same_v<T, float>) {
|           ^~~~~~~~~
|   pennylane_lightning/src/StateVector.cpp:19:46: error: expected ‘}’ at end of input
|    template class Pennylane::StateVector<double>;
|                                                 ^
|   pennylane_lightning/src/StateVector.cpp: At global scope:
|   pennylane_lightning/src/StateVector.cpp:19:46: error: expected ‘}’ at end of input
|   pennylane_lightning/src/StateVector.cpp:19:46: error: expected ‘}’ at end of input
|   error: command 'gcc' failed with exit status 1

Additional information

Any additional information, configuration or data that might be necessary
to reproduce the issue.

@mlxd mlxd added the bug Something isn't working label Jul 28, 2021
@mlxd
Copy link
Member Author

mlxd commented Jul 29, 2021

The root cause of this seems to be the older version of GCC/G++ in the wheel-builder image for PPC, as discussed here. I will use the manylinux2014 image, which is modern enough for our needs.

@mlxd
Copy link
Member Author

mlxd commented Aug 9, 2021

Fixed in PR #120. Closing.

@mlxd mlxd closed this as completed Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant