Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RefreshKeys approach not workable #1925

Open
bbockelm opened this issue Jan 22, 2025 · 0 comments
Open

RefreshKeys approach not workable #1925

bbockelm opened this issue Jan 22, 2025 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@bbockelm
Copy link
Collaborator

This is a deferred work item from #1748.

The RefreshKeys API is flawed. It doesn't work reliably as it assumes there are no updates missed (updates that could occur when the host is offline or if there's other RefreshKeys calls added in the future).

We should expand things so we;

  • Periodically register the keys regardless (can be tens of minutes between periods).
  • Always register the keys on startup.
  • Either prevent missing updates or detect missed updates. Two possible approaches:
    • Allow a callback to be registered by launcher_utils in config. This requires config to have an active goroutine running which I don't particularly like.
    • Have the RefreshKeys become something that computes a stable tag (version number, checksum) and returns it. Then the loop can detect if the tag has changed since the last time.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants