Skip to content
This repository has been archived by the owner on Dec 22, 2021. It is now read-only.

Change CreatePrivacyGroup and FindPrivacyGroup to return the same type #257

Merged

Conversation

josh-richardson
Copy link
Contributor

CreatePrivacyGroup and FindPrivacyGroup previously returned separate types leading to slightly different results when serialized to JSON. This unifies the return types to PrivacyGroup.

@CLAassistant
Copy link

CLAassistant commented Jul 15, 2019

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@iikirilov iikirilov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lucassaldanha lucassaldanha merged commit cc0709e into Consensys:master Jul 16, 2019
@josh-richardson josh-richardson deleted the consistent-return-type branch September 2, 2019 18:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants