Skip to content
This repository has been archived by the owner on Jun 3, 2024. It is now read-only.

Add classes and fields to ForgeHooks, which might be used by hacky mods #161

Merged
merged 1 commit into from
Jul 30, 2020

Conversation

rikka0w0
Copy link
Contributor

@rikka0w0 rikka0w0 commented Jul 29, 2020

This fix makes https://github.com/MinecraftModDevelopmentMods/AdditionalLootTables/tree/master-1.15.2 work.
By design, AdditionalLootTables 1.15.2 should also work in 1.14.4. Without coremoding, in order to append items to an existing loottable, Forge mods have to use reflection on ForgeHooks.lootContext.

@kitlith
Copy link
Contributor

kitlith commented Jul 29, 2020

Don't have to deal with this right now, but I wonder how #139 would change things, since that isn't using the LootTableContext struct anymore internally. EDIT: it would work, but kinda only coincidentally since it's setting the name, which is the only thing the relevant hook looks for in that PR. :/

Overall, the changes here make sense to me.

@florensie florensie changed the title Add classes and fields to ForgeHooks, which might be use by hacky mods Add classes and fields to ForgeHooks, which might be used by hacky mods Jul 29, 2020
@TheGlitch76 TheGlitch76 merged commit 2d2cc76 into master Jul 30, 2020
@TheGlitch76 TheGlitch76 deleted the bugfix/lootcontext branch July 30, 2020 18:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants