Skip to content

Commit 912680e

Browse files
committedMay 23, 2019
Merge dashpay#561: Respect LDFLAGS and #undef STATIC_PRECOMPUTATION if using basic config
dbed75d Undefine `STATIC_PRECOMPUTATION` if using the basic config (DesWurstes) 310111e Keep LDFLAGS if `--coverage` (DesWurstes) Pull request description: Update: **This is a trimmed pull request with strong rationale.** - Adding `--coverage` shouldn't reset `LDFLAGS`, this is definitely a typo - The basic configuration should undefine `STATIC_PRECOMPUTATION`, as generating it is not supported and it complicates dashpay#549 Tree-SHA512: 29f0dd4c870ec60d535346446b453da459ca843ed1265c2bc966bf0fcbdf3c5c79f9e48a419662e81d790a7003f8877a16e2a5a74aa5c0b79645e15ad56a0f66
2 parents 91fae3a + dbed75d commit 912680e

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed
 

‎configure.ac

+1-1
Original file line numberDiff line numberDiff line change
@@ -156,7 +156,7 @@ AC_CHECK_TYPES([__int128])
156156
if test x"$enable_coverage" = x"yes"; then
157157
AC_DEFINE(COVERAGE, 1, [Define this symbol to compile out all VERIFY code])
158158
CFLAGS="$CFLAGS -O0 --coverage"
159-
LDFLAGS="--coverage"
159+
LDFLAGS="$LDFLAGS --coverage"
160160
else
161161
CFLAGS="$CFLAGS -O3"
162162
fi

‎src/basic-config.h

+1
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
#ifdef USE_BASIC_CONFIG
1111

1212
#undef USE_ASM_X86_64
13+
#undef USE_ECMULT_STATIC_PRECOMPUTATION
1314
#undef USE_ENDOMORPHISM
1415
#undef USE_FIELD_10X26
1516
#undef USE_FIELD_5X52

0 commit comments

Comments
 (0)