Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alternative refspecs #361

Merged
merged 2 commits into from
Feb 6, 2015
Merged

Alternative refspecs #361

merged 2 commits into from
Feb 6, 2015

Conversation

thefringeninja
Copy link
Contributor

No description provided.

@thefringeninja
failing test
4a432bf 
Our branch specification in teamcity is like so:

+:refs/heads/*
+:refs/pull/(*/merge)
-:rr-cache

as per the official recommendation: http://blog.jetbrains.com/teamcity/2013/02/automatically-building-pull-requests-from-github-with-teamcity/
@thefringeninja
changed the regex to allow +:refs/heads/*
dd528b0
@SimonCropp
Copy link
Contributor

@thefringeninja this looks good. but what tooling r u using to get that format?

@thefringeninja
Copy link
Contributor Author

I just did what the blog post told me :)

On Thu, Feb 5, 2015 at 11:15 PM, Simon Cropp notifications@github.com
wrote:

@thefringeninja https://github.com/thefringeninja this looks good. but
what tooling r u using to get that format?

—
Reply to this email directly or view it on GitHub
#361 (comment)
.

Sent from my regular computer
http://twitter.com/thefringeninja
http://www.thefringeninja.com/

@gep13
Copy link
Member

gep13 commented Feb 6, 2015

I just did what the blog post told me :)

Which blog post? What CI system are you using?

@nulltoken
Copy link
Contributor

I'm curious too. From a CI perspective, it'd quite strange to actually rely on the tip of the branch rather than on the merge commit. 😕

@JakeGinnivan
Copy link
Contributor

http://blog.jetbrains.com/teamcity/2013/02/automatically-building-pull-requests-from-github-with-teamcity

I told @thefringeninja to make this change, while suggesting he switch to the merge commit instead. I think we should support it

@SimonCropp
Copy link
Contributor

no objections here. the change is fairly harmless

@JakeGinnivan
Copy link
Contributor

Yeah, it is more from a wtf why is gitversion not detecting my PR and versioning it like it says it should.

JakeGinnivan added a commit that referenced this pull request Feb 6, 2015
@JakeGinnivan
Merge pull request #361 from thefringeninja/alternative-refspecs
8b994aa 
Alternative refspecs
@JakeGinnivan JakeGinnivan merged commit 8b994aa into GitTools:master Feb 6, 2015
@gep13
Copy link
Member

gep13 commented Feb 6, 2015

Ah, I see. Yip, no objections from me.

@thefringeninja thefringeninja deleted the alternative-refspecs branch February 6, 2015 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@thefringeninja @SimonCropp @gep13 @nulltoken @JakeGinnivan