-
Notifications
You must be signed in to change notification settings - Fork 649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Command line not generating proper AssemblyVersion #252
Comments
There is definitely some sort of inconsistency here. If you look at what GitVersion is outputing in the JSON response you can see:
If these properties names are to be taken at face value, then they should map directly to the properties in the AssemblyInfo file. I know that there are some "problems" when bumping the AssemblyVersion number too often in terms of references within projects, is that why this decision has been taken? |
I should mention that the resulting assembly attributes are used to along with the |
Can you try to use the strict assembly versioning strategy? On Wed, Sep 10, 2014 at 8:43 PM, Sean Kearney notifications@github.com
|
Ah, now this makes more sense. FWIW, since GitVersion is marketed as "Use convention to derive a SemVer product version from a GitFlow based repository" I think that |
Maybe I am missing it, but it looks like that is only supported with the MSBuild Task. I am working with the Command Line. |
Pretty sure this is sorted in v2 We now default to using Major.Minor.Patch for the version (used to be Major.Minor). You can also change this using Reopen or let us know if it is still an issue |
Actually, just noticed this is still not right...
|
Fixed this properly in 3.0 release branch |
The
AssemblyVersion
attribute appears to be generated incorrectly.GitVersion output
Generated Attributes:
I would expect
[assembly: AssemblyVersion("1.0.1.0")]
This line appears to be the issue: https://github.com/Particular/GitVersion/blob/a78ef71d41406a223a87e599e2ef9e888449b23d/GitVersionExe/AssemblyInfoFileUpdate.cs#L34
Thoughts?
The text was updated successfully, but these errors were encountered: